Re: [PATCH v4 1/1] mfd: Add Host Interface (HIF) support for Nuvoton NCT6694
From: Guenter Roeck
Date: Fri May 15 2026 - 10:12:23 EST
On 5/15/26 05:41, Andrew Lunn wrote:
Add my influence as hardware monitoring maintainer. I very much agree.MAINTAINERS | 1 +
drivers/gpio/gpio-nct6694.c | 7 -
drivers/hwmon/nct6694-hwmon.c | 21 -
drivers/i2c/busses/i2c-nct6694.c | 7 -
drivers/mfd/Kconfig | 47 +-
drivers/mfd/Makefile | 3 +-
drivers/mfd/nct6694-hif.c | 663 ++++++++++++++++++++++++++++
drivers/mfd/nct6694.c | 111 +++--
drivers/net/can/usb/nct6694_canfd.c | 6 -
The networking change here is very small, so my influence as a
networking Maintainer should be considered small.
However, i would say this patch is too big, does too many different
things at once, making it harder to review. Please could you break it
up into lots of small patches, each with good commit messages, and
being obviously correct.
Guenter