Re: [PATCH] sched/rt: Have RT_PUSH_IPI be default off for non PREEMPT_RT

From: Steven Rostedt

Date: Fri May 15 2026 - 10:34:05 EST


On Fri, 15 May 2026 10:31:10 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> diff --git a/kernel/sched/features.h b/kernel/sched/features.h
> index 84c4fe3abd74..cce6d4159284 100644
> --- a/kernel/sched/features.h
> +++ b/kernel/sched/features.h
> @@ -110,8 +110,16 @@ SCHED_FEAT(WARN_DOUBLE_CLOCK, false)
> * rq lock and possibly create a large contention, sending an
> * IPI to that CPU and let that CPU push the RT task to where
> * it should go may be a better scenario.
> + *
> + * This is best for PREEMPT_RT, but for non-RT it can cause issues
> + * when preemption is disabled for long periods of time. Have
> + * it only default enabled for PREEMPT_RT.
> */
> +# ifdef CONFIG_PREEMPT_RT
> SCHED_FEAT(RT_PUSH_IPI, true)
> +#else
> +SCHED_FEAT(RT_PUSH_IPI, false)
> +#endif

I just noticed that the #endif should be:

# endif

to match the indentation of the # ifdef.

I'll send a v2.

-- Steve

> #endif