Re: [PATCH v2 2/3] x86/cpu/intel: Simplify F00F bug notice using pr_notice_once()
From: Ahmed S. Darwish
Date: Fri May 15 2026 - 15:14:20 EST
Hi Sohil,
On Thu, 14 May 2026, Sohil Mehta wrote:
>
> --- a/arch/x86/kernel/cpu/intel.c
> +++ b/arch/x86/kernel/cpu/intel.c
> @@ -396,13 +396,8 @@ static void intel_workarounds(struct cpuinfo_x86 *c)
> * The Quark is also family 5, but does not have the same bug.
> */
> if (c->x86_vfm >= INTEL_FAM5_START && c->x86_vfm < INTEL_QUARK_X1000) {
> - static int f00f_workaround_enabled;
> -
> set_cpu_bug(c, X86_BUG_F00F);
> - if (!f00f_workaround_enabled) {
> - pr_notice("Intel Pentium with F0 0F bug - workaround enabled.\n");
> - f00f_workaround_enabled = 1;
> - }
> + pr_notice_once("Intel Pentium with F0 0F bug - workaround enabled.\n");
> }
>
I think you can go further and just remove the whole dmesg line.
All other set_cpu_bug() call sites in the kernel do not print anything [*],
and /proc/cpuinfo already has a dedicated CPU bugs line.
Thanks,
Ahmed
[*] Except a single, also legacy, call site: X86_BUG_FDIV