Re: [PATCH] net: phy: honor eee_disabled_modes in phy_support_eee()

[Nicolai Buchwitz]

On 16.5.2026 06:51, Nicolai Buchwitz wrote:
> phy_support_eee() copies supported_eee into advertising_eee
> unconditionally, overwriting any filtering applied during phy_probe()
> based on DT eee-broken-* properties or driver-populated
> eee_disabled_modes. MAC drivers that call phy_support_eee() after
> probe (e.g. bcmgenet, fec, lan743x, lan78xx, r8169) then cause the PHY
> to advertise EEE for modes the user marked as broken.
>
> The symptom is that ethtool --show-eee on the local interface reports
> "not supported" (supported & ~eee_disabled_modes is empty) while the
> link partner sees EEE negotiated and active.
>
> phy_probe() already filters advertising_eee via eee_disabled_modes
> after calling of_set_phy_eee_broken(). Apply the same mask in
> phy_support_eee() so the filtering survives the copy.
>
> Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC 
> support EEE")
> Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>
> ---

> [...]


Sorry for the noise, this patch is missing the net prefix in the 
subject. Will resend as v2 with the correct prefix tomorrow. Still 
learning b4...

Have a nice weekend,
Nicolai