Re: [PATCH] hwmon: (lm75) Add explicit header include
From: Guenter Roeck
Date: Sat May 16 2026 - 08:27:17 EST
On Sat, May 16, 2026 at 10:57:08AM +0300, Flaviu Nistor wrote:
> Since device_property_read_string() is used in the
> probe function add explicit include for
> linux/mod_devicetable.h and linux/property.h rather
> than having implicit inclusions.
> Header linux/of.h can be removed and also of_match_ptr()
> improving non-Device Tree compatibility of the driver.
>
Line breaks should be at column 75. There are way too many line breaks
above.
> ---
> drivers/hwmon/lm75.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index 845a0e09ea9f..32279049d44c 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -14,7 +14,8 @@
> #include <linux/i3c/device.h>
> #include <linux/hwmon.h>
> #include <linux/err.h>
> -#include <linux/of.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/property.h>
> #include <linux/regmap.h>
> #include <linux/util_macros.h>
> #include <linux/regulator/consumer.h>
> @@ -1152,7 +1153,7 @@ static struct i2c_driver lm75_i2c_driver = {
> .class = I2C_CLASS_HWMON,
> .driver = {
> .name = "lm75",
> - .of_match_table = of_match_ptr(lm75_of_match),
> + .of_match_table = lm75_of_match,
With this, the __maybe_unused in the declaration of lm75_of_match
is no longer necessary. Please drop.
Thanks,
Guenter