Re: [PATCH v4 0/2] add support for Microchip PAC194X Power Monitor

[Andy Shevchenko]

On Fri, May 15, 2026 at 12:29:44PM +0300, marius.cristea@xxxxxxxxxxxxx wrote:

> Add support for Microchip PAC194X and PAC195X series of Power Monitor
> with Accumulator chip family. This driver covers the following part
> numbers:
>  - PAC1941, PAC1941-2, PAC1942, PAC1942-2, PAC1943, PAC1944
>  - PAC1951, PAC1951-2, PAC1952, PAC1952-2, PAC1953, PAC1954
> 
> The PAC194X family supports 9V Full-Scale Range and the PAC195X supports
> 32V Full-Scale Range.
> 
> There are two versions of the PAC194X/5X: the PAC194X-1/5X-1 devices are
> for high-side current sensing and the PAC194X/5X-2 devices are for low-side
> current sensing or floating VBUS applications. The PAC194X/5X-1 is named
> shortly PAC194X/5X.

It still has many subtle issues...

I am not able to review in a couple of weeks, so I recommend to read mailing lists
for the previous reviews against other big driver submissions and improve yours
accordingly.

So far, on a very fast glance I have noticed:
- the IWYU principle is not being followed
- the Kconfig help text can be improved to list part numbers for better
  maintainability

-- 
With Best Regards,
Andy Shevchenko