Re: [PATCH v6 08/14] media: iris: Rename clock and power domain macros to use vcodec suffix

[Dmitry Baryshkov]

On Fri, May 15, 2026 at 04:51:23PM +0530, Vishnu Reddy wrote:
> The current clock and power domain enum names are too generic. Rename
> them with a vcodec prefix to make the names more meaningful.
> 
> Glymur platform has three AXI clocks: axi_vcodec0, axi_ctrl, and
> axi_vcodec1. Positional names like AXI0, AXI1, AXI2 do not tell what each
> clock is for. Descriptive names like AXI_VCODEC_CLK and AXI_CTRL_CLK make
> the purpose clear and also make it easy to add secondary core (vcodec1)
> enums for the glymur platform.
> 
> No functional changes.
> 
> Reviewed-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>
> Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
> ---
>  .../platform/qcom/iris/iris_platform_common.h      | 22 +++---
>  .../platform/qcom/iris/iris_platform_sc7280.h      | 10 +--
>  .../platform/qcom/iris/iris_platform_sm8250.h      |  6 +-
>  .../platform/qcom/iris/iris_platform_sm8550.h      |  6 +-
>  .../platform/qcom/iris/iris_platform_sm8750.h      | 12 +--
>  drivers/media/platform/qcom/iris/iris_vpu3x.c      | 25 +++---
>  drivers/media/platform/qcom/iris/iris_vpu4x.c      | 90 +++++++++++-----------
>  drivers/media/platform/qcom/iris/iris_vpu_common.c | 45 +++++------
>  8 files changed, 110 insertions(+), 106 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h
> index 84fc68128c70..07cc0ce25b84 100644
> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h
> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h
> @@ -51,17 +51,17 @@ extern const struct iris_platform_data sm8650_data;
>  extern const struct iris_platform_data sm8750_data;
>  
>  enum platform_clk_type {
> -	IRIS_AXI_CLK, /* AXI0 in case of platforms with multiple AXI clocks */
> +	IRIS_AXI_VCODEC_CLK,

I really wonder... Why do you have IRIS_AXI_VCODEC_CLK and
IRIS_VCODEC_AHB_CLK in the same patch, targeting consistency.

That's not consistent at all...

>  	IRIS_CTRL_CLK,
>  	IRIS_AHB_CLK,
> -	IRIS_HW_CLK,
> -	IRIS_HW_AHB_CLK,
> -	IRIS_AXI1_CLK,
> +	IRIS_VCODEC_CLK,
> +	IRIS_VCODEC_AHB_CLK,
> +	IRIS_AXI_CTRL_CLK,
>  	IRIS_CTRL_FREERUN_CLK,
> -	IRIS_HW_FREERUN_CLK,
> -	IRIS_BSE_HW_CLK,
> -	IRIS_VPP0_HW_CLK,
> -	IRIS_VPP1_HW_CLK,
> +	IRIS_VCODEC_FREERUN_CLK,
> +	IRIS_VCODEC_BSE_CLK,
> +	IRIS_VCODEC_VPP0_CLK,
> +	IRIS_VCODEC_VPP1_CLK,
>  	IRIS_APV_HW_CLK,
>  };
>  

-- 
With best wishes
Dmitry