Re: [PATCH v3 00/10] iio: accel: mma8452: improve coding style, pm and resource cleanup
From: Sanjay Chitroda
Date: Sun May 17 2026 - 16:09:51 EST
On Tue, May 05, 2026 at 11:16:30PM +0530, Sanjay Chitroda wrote:
> From: Sanjay Chitroda <sanjayembeddedse@xxxxxxxxx>
>
> Hi all,
>
> This series contains a small fixes, cleanup and improvements to use
> modern kernel helper API and coding style for mma8452 accel driver.
>
> The changes modernize mutex with guard(), dev_err_probe usage,
> resolve checkpatch CHECKS and pm_ptr macro usage.
>
> Changes in v3:
> - Following input from Andy and Jonathan added new changes as following
> 0001: handle return value to have proper error propagation
> 0002: use non-devm API to maintain resource management LIFO order
> 0006: convert individual regulator using bulk regulator API
> 0009: use IIO cleanup helper for DIRECT_MODE
> - Address kernel coding stype specific review comment
> - Reorder local struct device and dev_err_probe change
> v2 series -> https://lore.kernel.org/all/20260422165643.2148195-1-sanjayembedded@xxxxxxxxx/
> Changes in v2:
> - 0005: address review comment from Andy and Geert
> and use DEFINE_RUNTIME_DEV_PM_OPS macro
> - Added new cleanup channges in mma8452 driver
>
> No functional behavior changes are intended.
>
> Testing:
> - Compiled with W=1
> - Build-tested on QEMU x86_64
>
> Feedback and reviews are very welcome.
>
> Thanks,
> Sanjay Chitroda
>
> Sanjay Chitroda (10):
> iio: accel: mma8452: handle I2C read error(s) in mma8452_read()
> iio: accel: mma8452: switch to non-devm request_threaded_irq()
> iio: accel: mma8452: cleanup codestyle warning
> iio: accel: mma8452: sort headers alphabetically
> iio: accel: mma8452: Use dev_err_probe()
> iio: accel: mma8452: convert to bulk regulator usage
> iio: accel: mma8452: use local struct device
> iio: accel: mma8452: use pm_ptr() and direct runtime PM calls
> iio: accel: mma8452: Use IIO cleanup helpers
> iio: accel: mma8452: use guard() to release mutexes
Hi Jonathan,
It's been about two weeks since the latest posting, and it looks like
there haven't been any major comments so far atleast on initial changes
of series. I also don't see any progress on the iio/tesing branch yet.
Could you please guide me on how you'd like me to take this series forward?
I'm happy to rework/resend partial/full if needed or wait further.
Thanks, Sanjay
>
> drivers/iio/accel/mma8452.c | 278 +++++++++++++++---------------------
> 1 file changed, 116 insertions(+), 162 deletions(-)
>
>
> base-commit: 39b80c5c9830d12d2d6531059001301c4265322a
> --
> 2.34.1
>