Re: Re: [PATCH v5 2/3] clk: eswin: Add eic7700 HSP clock driver

[Xuyang Dong]

> 
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [High] The Kconfig entry `COMMON_CLK_EIC7700_HSP` is missing a `select REGMAP_MMIO` dependency, causing linker errors under `COMPILE_TEST`.
> --
> 
> commit 1a3c5e0ea14d621d30772ac99cb5372fe67c5d6f
> Author: Xuyang Dong <dongxuyang@xxxxxxxxxxxxxxxxxx>
> 
> clk: eswin: Add eic7700 HSP clock driver
> 
> This commit adds the ESWIN EIC7700 high-speed peripherals system clock
> controller driver and registers an auxiliary device named hsp-reset.
> 
> > diff --git a/drivers/clk/eswin/Kconfig b/drivers/clk/eswin/Kconfig
> > index 0406ec499ec9c..e6cc2a407bac8 100644
> > --- a/drivers/clk/eswin/Kconfig
> > +++ b/drivers/clk/eswin/Kconfig
> > @@ -13,3 +13,15 @@ config COMMON_CLK_EIC7700
> >  	  SoC. The clock controller generates and supplies clocks to various
> >  	  peripherals within the SoC.
> >  	  Say yes here to support the clock controller on the EIC7700 SoC.
> > +
> > +config COMMON_CLK_EIC7700_HSP
> > +	tristate "EIC7700 HSP Clock Driver"
> > +	depends on ARCH_ESWIN || COMPILE_TEST
> > +	select AUXILIARY_BUS
> > +	select COMMON_CLK_EIC7700
> > +	select RESET_EIC7700_HSP if RESET_CONTROLLER
> 
> Does this Kconfig entry need to select REGMAP_MMIO?
> 

Hi Sashiko,

The next version will add 'select REGMAP_MMIO' in the Kconfig entry.

Best regards,
Xuyang Dong

> The driver calls devm_regmap_init_mmio() in eic7700_hsp_clk_probe(). When
> building under COMPILE_TEST on configurations where no other component
> coincidentally selects REGMAP_MMIO, this can result in an undefined
> reference to __devm_regmap_init_mmio_clk linker error.
> 
> > +	help
> > +	  This driver provides support for clock controller on ESWIN EIC7700
> > +	  HSP. The clock controller generates and supplies clocks to high
> > +	  speed peripherals within the SoC.
> > +	  Say yes here to support the clock controller on the EIC7700 HSP.
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260514114212.903-1-dongxuyang@xxxxxxxxxxxxxxxxxx?part=2