Re: [PATCH] Revert "mm: introduce a new page type for page pool in page type"
From: David Hildenbrand (Arm)
Date: Mon May 18 2026 - 04:25:55 EST
On 5/15/26 05:47, Byungchul Park wrote:
> This reverts commit db359fccf212e7fa3136e6edbed6228475646fd7.
>
> Netpp page_type'ed pages might be used in mapping so as to use
> @_mapcount. However, since @page_type and @_mapcount are union'ed in
> struct page, these two can't be used at the same time. Revert the
> commit introducing page_type for Netpp for now.
>
> The patch will be retried once @page_type and @_mapcount get allowed to
> be used at the same time.
>
> The revert also includes removal of @page_type initialization part
> introduced by commit 735a309b4bfb9e ("net: add net_iov_init() and use it
> to initialize ->page_type"), which will be restored on the retry.
>
> Reported-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/982b9bc1-0a0a-4fc5-8e3a-3672db2b29a1@xxxxxxxxxx
> Signed-off-by: Byungchul Park <byungchul@xxxxxx>
Too bad we didn't notice this earlier during testing in -next etc :(
vm_insert_page() sucks. I hope we can revisit this, once vm_insert_page() no
longer touches the mapcount.
Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>
--
Cheers,
David