Re: [PATCH 1/3] mmc: sdhci-of-dwcmshc: improve delay handling with fsleep()
From: Andy Shevchenko
Date: Mon May 18 2026 - 10:22:24 EST
On Mon, May 18, 2026 at 02:00:31PM +0300, Artem Shimko wrote:
> The driver currently uses udelay() for short delays, which performs
> busy-waiting and may not be optimal even for very short durations.
> While udelay() is appropriate for atomic context, these specific delays
> occur in non-atomic contexts where sleeping is allowed.
>
> Replace udelay(1) with fsleep(1) in dwcmshc_rk3568_set_clock() and
> rk35xx_sdhci_reset(). The fsleep() function automatically selects the
> optimal delay mechanism based on the requested duration - for
> delays <= 10 microseconds it will use udelay() internally, but provides
> better flexibility for future adjustments and makes the code more
> consistent with kernel best practices. No functional change is intended.
Read, what you wrote. With the above commit message this is no point in this
patch.
--
With Best Regards,
Andy Shevchenko