Re: [PATCH 1/2] iio: light: veml3328: add devicetree binding for new sensor
From: Joshua Crofts
Date: Mon May 18 2026 - 10:24:41 EST
On Sun, 17 May 2026 at 16:26, Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
>
> On Sun, 17 May 2026 at 15:11, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> >
> > On Sat, 16 May 2026 23:50:53 +0200
> > Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> >
> > > Add devicetree binding for the Vishay VEML3328 RGB/IR light sensor
> > > connected via I2C (SMBus compatible).
> > >
> > > Additionally, add an entry in MAINTAINERS.
> > >
> > > Signed-off-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> >
> > This is very standard looking. Have you considered if any similar
> > bindings can be easily extended to cover this device?
> >
> > Note that there is no direct relationship between bindings and
> > drivers, there are single bindings with multiple associated drivers
> > and multiple bindings covered by a single driver.
> > Also dt-bindings get used in multiple projects and some of those
> > will do different splits in what code covers what parts.
>
> Hmm, now that I think about it, the VEML6030 binding could be easily
> extended to support this device - oh well, should've checked earlier
> and it would've saved me a headache.
Before I forget, any idea if I should add an F: reference in the MAINTAINERS
file if I'm just expanding an existing .yaml file? Given I'm not the maintainer
of it, I'd expect to just have a reference to the actual driver file and not the
binding.
Thanks.
--
Kind regards
CJD