Re: [PATCH 1/3] mmc: sdhci-of-dwcmshc: improve delay handling with fsleep()
From: Andy Shevchenko
Date: Mon May 18 2026 - 14:35:29 EST
On Mon, May 18, 2026 at 05:50:55PM +0300, Artem Shimko wrote:
> On Mon, May 18, 2026 at 5:16 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > Read, what you wrote. With the above commit message this is no point in this
> > patch.
>
> I tried to replace *sleep() with fsleep() API. It seems I
> misunderstood the hint [1].
Yep, the hint was basically about uses of usleep_range(). udelay for 1 or 2
microseconds is fine as is. Of course for the sake of consistency it can be
moved to fsleep() (when the context is non-atomic), but solely udelay(1) -->
fsleep(1) makes no needed churn.
> Or is that the commit description mistake?
>
> Thank you for reviewing it.
>
> [1] https://lore.kernel.org/all/ad-mCsvOWWgqt-rc@ashevche-desk.local/
--
With Best Regards,
Andy Shevchenko