Re: [PATCH v6 00/14] Remove CONFIG_READ_ONLY_THP_FOR_FS and enable file THP for writable files

[Andrew Morton]

On Tue, 19 May 2026 07:39:07 +0800 Zi Yan <ziy@xxxxxxxxxx> wrote:

> On 19 May 2026, at 6:21, Andrew Morton wrote:
> 
> > On Sun, 17 May 2026 09:54:02 -0400 Zi Yan <ziy@xxxxxxxxxx> wrote:
> >
> >> Hi all,
> >>
> >> This patchset removes READ_ONLY_THP_FOR_FS Kconfig and enables creating
> >> file-backed THPs for FSes with large folio support (the supported orders
> >> need to include PMD_ORDER) by default, including for writable files.
> >
> > Cool.  Sashiko wasn't able to apply this (presumably because of Mike's
> > CI-friendly series).  I take it that the AI review from v5
> > (https://sashiko.dev/#/patchset/20260429152924.727124-1-ziy@xxxxxxxxxx)
> > was considered?
> >
> > Also, please check that the below were considered:
> >
> > https://lore.kernel.org/e9e61132-902a-445f-9c4c-4d405d164e70@xxxxxxxxxx
> > https://lore.kernel.org/22831162-abe7-4498-9e81-7f5aa3526d00@xxxxxxxxxx
> > https://lore.kernel.org/959238dd-2493-4d9c-ac35-6d04460a8239@xxxxxxxxxx
> > https://lore.kernel.org/1895A67C-BB1F-49EA-ADC3-AA4F51A6ED57@xxxxxxxxxx
> >
> > https://lore.kernel.org/20260508074643.55548-1-lance.yang@xxxxxxxxx
> > https://lore.kernel.org/b8a3c3eb-f241-40fe-9121-4ae5a1097807@xxxxxxxxxx
> >
> 
> I addressed all of them, except the second one and I will reply to the
> second one soon.

Great.

> >
> >> is an in-place replacement of V5 in mm-new. It affects Mike Rapoport's
> >> "make MM selftests more CI friendly", since "selftests/mm: khugepaged:
> >> use kselftest framework" needs to be updated. I updated it and put it at
> >> the end of this cover letter.
> >
> > Helpful, thanks.  It was a little complicated because your email client
> > messes with whitespace (it always has!), but I figured it out.
> 
> You mean tabs become whitespace? And does all my patches have the whitespace
> issue or the one I put at the bottom? I am trying to figure out the issue.
> BTW, All patches are sent via git send-email using mstmp and
> I copied the bottom one from git format-patch. I wonder which part went
> wrong.

Your regular patches are OK - but when you informally paste a patch
into the message body the tabs turn into whitespace.

You aren't the only one ;)   I usually don't comment...