Re: [PATCH net v2 1/2] net: phy: honor eee_disabled_modes in phy_support_eee()

[Nicolai Buchwitz]

Hi Andrew,

Thanks for your review.

On 19.5.2026 04:19, Andrew Lunn wrote:
> On Mon, May 18, 2026 at 10:23:09AM +0200, Nicolai Buchwitz wrote:
> > phy_support_eee() copies supported_eee into advertising_eee
> > unconditionally, overwriting any filtering applied during phy_probe()
> > based on DT eee-broken-* properties or driver-populated
> > eee_disabled_modes.
>
> Sorry, i should of questioned this on v1. What PHY are you using which
> masks advertising_eee in probe? It seems like this is wrong, and it
> should be setting >eee_disabled_modes, or maybe eee_supported.c

The masking isn't PHY-specific. phy_probe() applies eee_disabled_modes
to advertising_eee after of_set_phy_eee_broken() picks up the
eee-broken-* properties from the PHY DT node.

The PHYs in my case are BCM54210PE / BCM54213PE on Raspberry Pi
CM4 / 5, and I use eee-broken-* to disable EEE on boards where the
switch doesn't handle LPI well. phy_support_eee() then clobbers that
filtering by overwriting advertising_eee with the unfiltered
supported_eee.

> > Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC 
> > support EEE")
> > Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>
>
> This patch itself looks O.K.
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>
>     Andrew

Regards
Nicolai