Re: [PATCH net v2 2/2] net: phy: honor eee_disabled_modes in phy_advertise_eee_all()

[Andrew Lunn]

On Mon, May 18, 2026 at 10:23:10AM +0200, Nicolai Buchwitz wrote:
> phy_advertise_eee_all() copies supported_eee into advertising_eee
> unconditionally, overwriting any filtering applied during phy_probe()
> based on DT eee-broken-* properties or driver-populated
> eee_disabled_modes. genphy_c45_ethtool_set_eee() calls this helper
> when user space passes an empty advertisement, undoing the filtering.
> 
> Apply the same eee_disabled_modes mask in phy_advertise_eee_all() so
> the filtering survives the copy, matching the pattern in phy_probe()
> and phy_support_eee().
> 
> Fixes: b64691274f5d ("net: phy: add helper phy_advertise_eee_all")
> Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew