Re: [PATCH v4] nvmem: core: Default to read-only if wp-gpios present

From: Srinivas Kandagatla

Date: Tue May 19 2026 - 10:16:52 EST



On Fri, 08 May 2026 19:00:20 +0200, Marek Vasut wrote:
> In case the nvmem DT node contains "wp-gpios" DT property, the device
> currently defaults to read-write and the force_ro sysfs attribute reads
> 0. Switch to the default read-only, which is both safer, and aligned
> with eMMC HW BOOT partition force_ro sysfs attribute behavior, which
> also defaults to read-only.
>
> The adjustment of nvmem->read_only value to read-only in case wp-gpios
> DT property is present must be done only after the device_add() got
> called because device_add() does internally call nvmem_bin_attr_get_umode(),
> which configures the permissions of 'nvmem' bin attr based on the value
> of nvmem->read_only that is only parsed from DT property 'read-only',
> without any adjustment. This way, if DT property 'read-only' is present,
> the 'nvmem' attribute is always read-only. Otherwise, if the device is
> writeable, then 'nvmem' attribute is writeable, and nvmem->read_only
> defaults to read-only, but can be switched to read-write at runtime via
> the 'force_ro' attribute.
>
> [...]

Applied, thanks!

[1/1] nvmem: core: Default to read-only if wp-gpios present
commit: dc6e0711164504b5f0f858735cf973c965d16e6d

Best regards,
--
Srinivas Kandagatla <srini@xxxxxxxxxx>