Re: [PATCH v2 3/6] selftests: Remove unused LLD variable
From: Benjamin Tissoires
Date: Thu May 21 2026 - 11:50:37 EST
On May 18 2026, James Clark wrote:
> This file was mostly copied from selftests/bpf/Makefile, but the LLD
> variable is not used here. Also, this copied block didn't get the same
> fixes as the original one did later.
>
> Remove it to avoid confusion and so future fixes don't have to be in two
> places.
>
> Signed-off-by: James Clark <james.clark@xxxxxxxxxx>
> ---
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-7.2/bpf), thanks!
[3/6] selftests: Remove unused LLD variable
https://git.kernel.org/hid/hid/c/08918b98b02b
Cheers,
Benjamin
> tools/testing/selftests/hid/Makefile | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile
> index 50ec9e0406ab..96071b4800e8 100644
> --- a/tools/testing/selftests/hid/Makefile
> +++ b/tools/testing/selftests/hid/Makefile
> @@ -105,13 +105,6 @@ $(MAKE_DIRS):
> $(call msg,MKDIR,,$@)
> $(Q)mkdir -p $@
>
> -# LLVM's ld.lld doesn't support all the architectures, so use it only on x86
> -ifeq ($(SRCARCH),x86)
> -LLD := lld
> -else
> -LLD := ld
> -endif
> -
> DEFAULT_BPFTOOL := $(HOST_SCRATCH_DIR)/sbin/bpftool
>
> TEST_GEN_PROGS_EXTENDED += $(DEFAULT_BPFTOOL)
>
> --
> 2.34.1
>