Re: [PATCH v2 net-next 2/3] dt-bindings: dpll: add SiTime SiT9531x clock generator

[Ali Rouhi]

> Mismatched DCO. Use consistent identity or fix your commits.

Apologies — Gmail's SMTP relay rewrites the From header to my
personal address (rouhi.ali@xxxxxxxxx).  I'm working with IT to
get corporate SMTP credentials so the From matches the Signed-off-by
(arouhi@xxxxxxxxxx) in v3.

> Same as last time. Why are you describing drivers?

Will drop the clocks description entirely — maxItems and
clock-names are sufficient.

> Drop node. Wasn't here before, so why did you add it?
> Drop.

Will drop both xo and xo2 fixed-clock nodes from the examples.

Thanks for the review.

Best regards,
Ali

On Thu, May 21, 2026 at 12:26 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>
> On 20/05/2026 21:19, Ali Rouhi wrote:
> > Add device tree binding documentation for the SiTime SiT95316
> > and SiT95317 DPLL clock generators.
> >
> > Co-developed-by: Oleg Zadorozhnyi <Oleg.Zadorozhnyi@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Oleg Zadorozhnyi <Oleg.Zadorozhnyi@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Ali Rouhi <arouhi@xxxxxxxxxx>
>
> Mismatched DCO. Use consistent identity or fix your commits.
>
> > ---
> >  .../bindings/dpll/sitime,sit9531x.yaml        | 145 ++++++++++++++++++
> >  1 file changed, 145 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/dpll/sitime,sit9531x.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/dpll/sitime,sit9531x.yaml b/Documentation/devicetree/bindings/dpll/sitime,sit9531x.yaml
> > new file mode 100644
> > index 000000000000..ac88f2f0b2ae
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/dpll/sitime,sit9531x.yaml
> > @@ -0,0 +1,145 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/dpll/sitime,sit9531x.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: SiTime SiT9531x DPLL Clock Generator
> > +
> > +maintainers:
> > +  - Ali Rouhi <arouhi@xxxxxxxxxx>
> > +
> > +description: |
> > +  SiTime SiT95316 and SiT95317 are I2C-controlled programmable clock
> > +  generators with integrated DPLL for synchronization applications.  Both
> > +  variants contain four PLLs with automatic/manual reference selection,
> > +  DCO frequency adjustment, and phase offset measurement via an on-chip
> > +  TDC (Time-to-Digital Converter).
> > +
> > +  SiT95317 provides 4 inputs and 8 outputs; SiT95316 provides
> > +  4 inputs and 12 outputs.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - sitime,sit95316
> > +      - sitime,sit95317
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +    description:
> > +      External crystal/oscillator feeding the chip's XIN/XO_CLK input.
> > +      The chip's PLL Fvco is computed relative to this reference, so the
> > +      driver requires a non-zero rate at probe time.
>
> Same as last time. Why are you describing drivers?
>
> > +
> > +  clock-names:
> > +    items:
> > +      - const: xtal
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +    description:
> > +      GPIO connected to the chip's active-low reset pin (RESETB).
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +    description:
> > +      Interrupt from the chip's active-low INTRB output.  Asserted when
> > +      the device detects a status change such as lock acquisition or loss.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - clock-names
> > +
> > +allOf:
> > +  - $ref: /schemas/dpll/dpll-device.yaml#
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    xo: xo {
> > +        compatible = "fixed-clock";
> > +        #clock-cells = <0>;
> > +        clock-frequency = <48000000>;
> > +    };
>
> Drop node. Wasn't here before, so why did you add it?
>
>
> > +
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        dpll@68 {
> > +            compatible = "sitime,sit95317";
> > +            reg = <0x68>;
> > +            clocks = <&xo>;
> > +            clock-names = "xtal";
> > +        };
> > +    };
> > +
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    xo2: xo2 {
> > +        compatible = "fixed-clock";
> > +        #clock-cells = <0>;
> > +        clock-frequency = <48000000>;
> > +    };
>
> Drop.
>
> > +
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
>
>
>
> Best regards,
> Krzysztof