Re: [PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations
From: Dan Carpenter
Date: Fri May 22 2026 - 01:55:30 EST
On Thu, May 21, 2026 at 10:41:12PM +0800, Pang-Chun Liu wrote:
> rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status()
> are declared in rtl8192c_recv.h but neither has a definition anywhere
> in the driver, and there are no callers. Remove the dead declarations.
>
> Signed-off-by: Pang-Chun Liu <kevin95120@xxxxxxxxx>
> ---
This kind of commit doesn't get a Fixes tag since it's not a bug, but
I'm always interested to see how mistakes happen. It's better if the
commit message can say which commit added it. In this case the dead
code was added when we initially merged the driver so it's fine.
Reviewed-by: Dan Carpenter <error27@xxxxxxxxx>
regards,
dan carpenter