Re: [PATCH v4 3/4] cleanup: Annotate guard constructors with __nonnull()

From: Miguel Ojeda

Date: Tue May 26 2026 - 13:54:39 EST


On Tue, May 26, 2026 at 5:13 PM Dmitry Ilvokhin <d@xxxxxxxxxxxx> wrote:
>
> They usually don't collide, except for User Mode Linux builds, which
> include both kernel and userspace headers.

:(

What about other similar names? i.e. a variation of your option 2,
e.g. just `nonnull` (we also have others like that, i.e. no
underscore, e.g. `noinline`), or `___nonnull` (triple underscore, but
may be confusing), or a suffix/prefix letter, e.g. `__knonnull` (for
kernel nonnull)...

i.e. it would be nice to have a "standard" spelling for ourselves, and
also replace the existing `__attribute__((nonnull))`s we have
elsewhere in the tree.

Cheers,
Miguel