Re: [RFC PATCH v5 1/2] vfs: add O_CREAT|O_DIRECTORY to open*(2)

[Askar Safin]

Jori Koolstra <jkoolstra@xxxxxxxxx>:
> +static inline umode_t o_create_mode(struct mnt_idmap *idmap,
> +		const struct inode *dir, umode_t mode, bool create_dir)
> +{
> +	return create_dir ? vfs_prepare_mode(idmap, dir, mode, S_IRWXUGO | S_ISVTX, 0)
> +			  : vfs_prepare_mode(idmap, dir, mode, S_IALLUGO, S_IFREG);

checkpatch says here:
WARNING: Symbolic permissions 'S_IRWXUGO' are not preferred. Consider using octal permissions '0777'.
#4361: FILE: fs/namei.c:4361:
+       return create_dir ? vfs_prepare_mode(idmap, dir, mode, S_IRWXUGO | S_ISVTX, 0)


-- 
Askar Safin