Re: [PATCH net-next v2 09/10] net: phy: Add support for the ADIN1140 PHY

[Andrew Lunn]

> +static int adin1140_config_aneg(struct phy_device *phydev)
> +{
> +	/* phylib tries to clear BIT(12) in MDIO_CTRL1, since AN is disabled.
> +	 * However, on the ADIN1140, that field is non-standard, being used
> +	 * to control the reset status of the PHY (thus it needs to remain set).

More brokenness. 802.3 defines PMA/PMD control 1 bit 12 as reserved
and always 0.

How did this chip get passed QA with so many issues?

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew