RE: [PATCH v2 2/7] pinctrl: renesas: rzg2l: Drop defines present in struct rzg2l_hwcfg

[Biju Das]

> -----Original Message-----
> From: Claudiu Beznea <claudiu.beznea@xxxxxxxxxx>
> Sent: 28 May 2026 09:46
> Subject: Re: [PATCH v2 2/7] pinctrl: renesas: rzg2l: Drop defines present in struct rzg2l_hwcfg
> 
> Hi, Biju,
> 
> On 5/28/26 11:16, Biju Das wrote:
> >> @@ -3816,9 +3814,9 @@ static const struct rzg2l_hwcfg rzg2l_hwcfg = {
> >>   	.regs = {
> >>   		.pwpr = 0x3014,
> >>   		.sd_ch = 0x3000,
> >> +		.qspi = 0x3008,
> >>   		.eth_poc = 0x300c,
> >>   		.oen = 0x3018,
> >> -		.qspi = QSPI,
> > Any reason for moving the assignment?
> 
> I tried to keep it sorted by the register offsets but it seems the pwpr is not in the right place
> either for this.

Ok.

Cheers,
Biju

> >
> > struct rzg2l_register_offsets {
> > 	u16 pwpr;
> > 	u16 sd_ch;
> > 	u16 eth_poc;
> > 	u16 oen;
> > 	u16 qspi;
> > 	u16 other_poc;
> > };
> >
> > Cheers,
> > Biju
> 
> --
> Thank you,
> Claudiu