Re: [PATCH v3 1/2] selftests/mm: refactor pkey test helpers and unify assertions

From: Mike Rapoport

Date: Thu May 28 2026 - 07:15:57 EST


On Thu, May 28, 2026 at 05:13:00PM +0800, Hongfu Li wrote:
> Hi Mike,
> Thanks for the review comments.
>
> > > Move shared tracing and assertion helpers to a common file, then
> > > convert the sighandler test to use pkey_assert() for consistent
> > > diagnostic output, and add per-test tracing around test execution.
> >
> > This sounds like three patches to me.
>
> Got it, should I split this into three individual patches?

Yes please.

> Best regards,
> Hongfu

--
Sincerely yours,
Mike.