Re: [PATCH v5 2/2] scsi: ufs: core: Add support for static TX Equalization settings

[Peter Wang (王信友)]

On Fri, 2026-05-29 at 16:12 +0800, Can Guo wrote:
> > > +static void ufshcd_parse_static_tx_eq_settings(struct ufs_hba
> > > *hba)
> > > +{
> > > +       const u32 lpd = hba->lanes_per_direction;
> > > +       const u32 num_elems = lpd * 2;
> > > +       int gear;
> > > +
> > > +       if (!lpd) {
> > > +               return;
> > > +       } else if (lpd > UFS_MAX_LANES) {
> > 
> > Unnecessary else if after return.
> You mean removing 'else if (lpd > UFS_MAX_LANES)' and the dev_warn()?
> 
> Thanks,
> Can Guo.
> 

Hi Can,

No, what I mean is that the check below aligns better with 
kernel code style:

if (!lpd)
    return;

if (lpd > UFS_MAX_LANES) {
    ...
}

Thanks
Peter