Re: [PATCH v2] pinctrl: qcom: Replace open coded eoi call with irq_chip_eoi_parent()

[Linus Walleij]

On Fri, May 29, 2026 at 10:09 AM Maulik Shah
<maulik.shah@xxxxxxxxxxxxxxxx> wrote:

> Before commit 14dbe186b9d4 ("pinctrl: msmgpio: Make the irqchip immutable")
> msm gpio irqchip conditionally initialized pctrl->irq_chip.irq_eoi to
> irq_chip_eoi_parent() only for the GPIO irqs having a wakeup capable irq.
>
> In order to make gpio irqchip immutable pctrl->irq_chip.irq_eoi is
> initialized to msm_gpio_irq_eoi() which now gets invoked for both wake up
> and non-wakeup capable GPIO IRQs.
>
> Replace open coded eoi call to parent irqchip with irq_chip_eoi_parent().
>
> Since the irq_chip_*_parent() APIs internally do not check the valid parent
> data is present to ensure irq_chip_eoi_parent() is only invoked for wakeup
> capable GPIOs validate d->parent_data within msm_gpio_irq_eoi().
>
> For non wakeup capable GPIOs d->parent_data will be NULL since parent
> irqchip diconnects hierarchy using irq_domain_disconnect_hierarchy() and
> later irq framework trims hierarchy using irq_domain_trim_hierarchy() which
> makes d->parent_data as NULL.
>
> No functional impact.
>
> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>
> Signed-off-by: Maulik Shah <maulik.shah@xxxxxxxxxxxxxxxx>

Patch applied!

Yours,
Linus Walleij