Re: [PATCH v2 14/15] arm64: defconfig: cleanup the defconfig
From: Krzysztof Kozlowski
Date: Sat May 30 2026 - 05:57:54 EST
On 30/05/2026 11:26, Dario Binacchi wrote:
> On Sat, May 30, 2026 at 11:01 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On 29/05/2026 16:46, Dario Binacchi wrote:
>>> Cleanup defconfig by doing:
>>>
>>> make defconfig
>>> make savedefconfig
>>> cp defconfig arch/arm64/configs/defconfig
>>>
>>> No functional change. The goal here is to cleanup defconfig file to make
>>> easier and cleaner the addition of new entries.
>>>
>>> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
>>
>>
>> NAK, you just ignored entire feedback.
>
> As I reported in the cover letter:
>
> Following Arnd's guidance [1], patch 14/15 "arm64: defconfig: cleanup
> the defconfig"
> is kept in this series purely for review purposes. Since a better
> version of this
> change has already been merged via Krzysztof's cleanups, this patch
> will be skipped
> once the review is complete.
>
> I kept it here only to provide the proper context and clean diff for
> reviewing the
> next patch: 15/15 "arm64: defconfig: enable configs for Engicam
> MicroGEA-STM32MP257-RMM".
We don't read cover letter. Your patch - if should be ignored - must be
marked appropriately in the subject or changelog.
But more important - this is still wrong process as it CANNOT be
applied. Last patch cannot go via maintainer's tree without this one in
such case. Plus, you are not supposed to duplicate patches already
accepted and linux-next would point you there.
Best regards,
Krzysztof