Re: [PATCH v6 0/2] Pinefeat cef168 lens control board driver

[Alen Karnil]

On 30/05/2026 12:46, Aliaksandr Smirnou wrote:
> On Thu, 28 May 2026 09:36:13 +0100, Alen Karnil wrote:
>
> > > Could you please ensure you are using the Makefile provided in the cef168
> > > repository?
> > ```
> > $ make
> > make -C "/lib/modules/`uname -r`/build" M="/home/admin/work/cef168"
> > DTC_INCLUDE="/usr/src/linux-headers-`uname -r | sed
> > 's/rpt-.*/rpt-common-rpi/'`/include"
> > make[1]: Entering directory '/home/admin/linux'
> > make[2]: Entering directory '/home/admin/work/cef168'
> >     CC [M]  cef168.o
> > make[4]: *** No rule to make target 'imx477.dtbo', needed by
> > 'modules.order'.  Stop.
> > make[3]: *** [/home/admin/linux/Makefile:2024: .] Error 2
> > make[2]: *** [/home/admin/linux/Makefile:248: __sub-make] Error 2
> > make[2]: Leaving directory '/home/admin/work/cef168'
> > make[1]: *** [Makefile:248: __sub-make] Error 2
> > make[1]: Leaving directory '/home/admin/linux'
> > make: *** [Makefile:16: default] Error 2
> > ```
> >
> > This is what I got hung up on, which is why I moved onto copying the
> > .dts* and building it from the kernel directory, which lead into the
> > previous issue and me needing to roll my own .dts*
>
> Could you pull the latest version of the main branch from the cef168
> repository? This issue was fixed recently, so it looks like the code
> you pulled was from before that fix was merged.
>
> The fix involved using the dtb-y target instead of obj-m in the Makefile.

Just tested it, now it works, thanks.
> > > Will do. Should I update the patch before or after your review?
> >
> > I would prefer if you were to update it before just so we are in sync,
> > thank you.
>
> Will do.

I will continue the review once it's received.