Re: [RFC PATCH v3 2/4] rust: add minimal IIO subsystem abstractions

[Jonathan Cameron]

On Mon, 1 Jun 2026 15:30:40 +0700
Muchamad Coirul Anwar <muchamadcoirulanwar@xxxxxxxxx> wrote:

> On Thu, 28 May 2026 17:09:00 +0100
> Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
Hi Coirul,

A small kernel review process thing.  You need to keep more context.
A reader shouldn't need to go open previous email just to find
out what code we are talking about. Take a look at other review
discussions on the mailing lists you are sending this to.
(though oddly this pattern has become a common thing in last week or
 so - hence I'm sending this comment a lot!)



> 
> > why .get() for this one.  
> 
> I used .get() because NonZeroI32 is a wrapper type, meaning we have to
> explicitly extract the
> inner i32. Since the other variants use a plain i32, they don't need
> it. I'll add a quick comment in
> v4 to clarify this.

Ah no need. That was my lack of rust knowledge.  You'll be helping
reviewers understand this stuff for a while!