Re: [PATCH v3 04/10] clk: qcom: clk-rpm: add msm8960 compatible
From: Antony Kurniawan Soemardi
Date: Mon Jun 01 2026 - 13:06:13 EST
On 6/1/2026 6:38 PM, Dmitry Baryshkov wrote:
On Mon, Jun 01, 2026 at 03:51:17PM +0700, Antony Kurniawan Soemardi via B4 Relay wrote:
From: Antony Kurniawan Soemardi <linux@xxxxxxxxxxxxxx>
Add support for the "qcom,rpmcc-msm8960" compatible string to the
RPM clock driver.
msm8960 uses the same RPM clock descriptions as apq8064, so reuse
rpm_clk_apq8064 for this compatible.
Tested-by: Rudraksha Gupta <guptarud@xxxxxxxxx>
Signed-off-by: Antony Kurniawan Soemardi <linux@xxxxxxxxxxxxxx>
---
drivers/clk/qcom/clk-rpm.c | 1 +
1 file changed, 1 insertion(+)
On the other hand... You have added APQ8064 strings as a fallback. Is
this change really needed until you actually have SoC-specific quirks?
The fallback was recommended by Konrad in the initial review:
https://lore.kernel.org/all/677f1d1d-a1fe-42ec-9e82-c9e504873c98@xxxxxxxxxxxxxxxx/
As for SoC specific quirks, I don't have anything planned right now about it though...
--
Thanks,
Antony K. S.