Re: [PATCH v3 2/2] arm64: kernel: Disable CNP on HiSilicon HIP09

[Zeng Heng]

Hi Will,

On 2026/6/2 23:53, Will Deacon wrote:
> On Mon, Jun 01, 2026 at 07:20:00PM +0800, Zeng Heng wrote:
> > diff --git a/arch/arm64/kernel/cpu_errata.c b/arch/arm64/kernel/cpu_errata.c
> > index b0db946568b7..02e0ee5c948c 100644
> > --- a/arch/arm64/kernel/cpu_errata.c
> > +++ b/arch/arm64/kernel/cpu_errata.c
> > @@ -608,6 +608,14 @@ static const struct midr_range erratum_ac04_cpu_23_list[] = {
> >   };
> >   #endif
> >
> > +#ifdef CONFIG_ARM64_WORKAROUND_DISABLE_CNP
> > +static const struct midr_range cnp_erratum_cpus[] = {
> > +	MIDR_ALL_VERSIONS(MIDR_NVIDIA_CARMEL),
> > +	MIDR_ALL_VERSIONS(MIDR_HISI_HIP09),
> > +	{},
> > +};
> > +#endif
> Sashiko [1] points out that this means that
> CONFIG_HISILICON_ERRATUM_162100125 now affects NVIDIA parts and
> vice-versa for CONFIG_NVIDIA_CARMEL_CNP_ERRATUM.
>
> The easiest fix is probably to guard the entries in the array above with
> their respective config options? Otherwise, this all looks good to me.
>
> Will
>
> [1] https://sashiko.dev/#/patchset/20260601112000.1145391-1-zengheng@xxxxxxxxxxxxxxx

Yes, that makes sense to me. Thanks for the reminder.

I'll apply the changes in v4.


Best regards,
Zeng Heng