Re: [patch V5 09/16] futex: Add support for unlocking robust futexes

From: Peter Zijlstra

Date: Wed Jun 03 2026 - 04:30:53 EST


On Tue, Jun 02, 2026 at 11:09:55AM +0200, Thomas Gleixner wrote:
> --- a/kernel/futex/futex.h
> +++ b/kernel/futex/futex.h
> @@ -40,6 +40,8 @@
> #define FLAGS_NUMA 0x0080
> #define FLAGS_STRICT 0x0100
> #define FLAGS_MPOL 0x0200
> +#define FLAGS_UNLOCK_ROBUST 0x0400
> +#define FLAGS_ROBUST_LIST32 0x0800
>
> /* FUTEX_ to FLAGS_ */
> static inline unsigned int futex_to_flags(unsigned int op)
> @@ -52,6 +54,12 @@ static inline unsigned int futex_to_flag
> if (op & FUTEX_CLOCK_REALTIME)
> flags |= FLAGS_CLOCKRT;
>
> + if (op & FUTEX_UNLOCK_ROBUST)
> + flags |= FLAGS_UNLOCK_ROBUST;
> +
> + if (op & FUTEX_ROBUST_LIST32)
> + flags |= FLAGS_ROBUST_LIST32;
> +
> return flags;
> }
>

Would you mind terribly if I did: 's/UNLOCK_ROBUST/ROBUST_UNLOCK/g' on
the whole series?

Then we get:

FUTEX_ROBUST_UNLOCK
FUTEX_ROBUST_LIST32

FLAGS_ROBUST_UNLOCK
FLAGS_ROBUST_LIST32

which to me looks just a tad better.

Anyway, let me continue staring at things.