Re: [PATCH 1/2] dt-bindings: hwmon: isl68137: Add RAA228234 compatible

[Conor Dooley]

On Wed, Jun 03, 2026 at 10:10:14PM +0530, Naresh Solanki wrote:
> Hi
> 
> 
> On Wed, 3 Jun 2026 at 21:39, Conor Dooley <conor@xxxxxxxxxx> wrote:
> >
> > On Wed, Jun 03, 2026 at 11:01:26AM +0000, Naresh Solanki wrote:
> > > From: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>
> > >
> > > Add the compatible string for the Renesas RAA228234 8-phase PWM
> > > controller, which shares the same PMBus interface as the RAA228228.
> >
> > Given this, and what the driver change looks like, why is a fallback
> > compatible not used?
> Are you suggesting that the binding should use renesas,raa228228 as a
> fallback compatible, similar to how renesas,raa228942 and
> renesas,raa228943 fall back to renesas,raa228244?

I didn't see that at the time (I commented on this diff alone), but yes.
 	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228234", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc },
driver change suggests you're compatible with the ..44 device.

I expect that you'll use a fallback in the next iteration then?
pw-bot: changes-requested

Cheers,
Conor.

> Or is there a
> specific reason you'd expect it not to be used here?
> 
> Regards,
> Naresh
> 
> >
> > >
> > > Signed-off-by: Patrick Rudolph <patrick.rudolph@xxxxxxxxxxxxx>
> > > Signed-off-by: Naresh Solanki <naresh.solanki@xxxxxxxxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > > index 8216cdf758d8..2988bc6300ae 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/isil,isl68137.yaml
> > > @@ -55,6 +55,7 @@ properties:
> > >            - renesas,raa228004
> > >            - renesas,raa228006
> > >            - renesas,raa228228
> > > +          - renesas,raa228234
> > >            - renesas,raa228244
> > >            - renesas,raa228246
> > >            - renesas,raa229001
> > > --
> > > 2.43.0
> > >

Attachment: signature.asc
Description: PGP signature