Re: [PATCH] pcmcia: cs: Replace manual mutex locking with guard(mutex)
From: Dominik Brodowski
Date: Thu Jun 04 2026 - 10:07:51 EST
Am Thu, Jun 04, 2026 at 08:26:59AM -0500 schrieb Maxwell Doose:
> Hi Dominik,
>
> On Thu, Jun 4, 2026 at 1:07 AM Dominik Brodowski
> <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Am Wed, Jun 03, 2026 at 01:27:12AM -0500 schrieb Maxwell Doose:
> > > The current code uses manual mutex locking. Replace it with the RAII
> > > guard(mutex) alongside some helpers to help condense some sections and
> > > increase readability.
> >
> > As the PCMCIA subsystem is in "odd fixes" mode, I don't see real advantages
> > for this patch.
> >
>
> Ah. Is that because not enough time or PCMCIA isn't in use much
> anymore? Or something else?
Both. If there are clear improvements (or even security-relevant fixes), I'm
happy to take patches, but otherwise PCMCIA is slowly on its way out.
Best,
Dominik