Re: [PATCH v6 10/12] x86/mm: Move flush_tlb_info back to the stack

[Dave Hansen]

On 5/28/26 08:13, Chuyi Zhou wrote:
> Commit 3db6d5a5ecaf ("x86/mm/tlb: Remove 'struct flush_tlb_info' from the
> stack") converted flush_tlb_info from stack variable to per-CPU variable.
> This brought about a performance improvement of around 3% in extreme test.

You've basically (nicely) thrown down the gauntlet and told Nadav that
his patch or methodology is bad. PeterZ also acked it Nadav's approach.

I think they should chime in before doing anything here.

Also, this patch does at least three different things:

1. Adds alignment for flush_tlb_info
2. Changes the signature of get_flush_tlb_info() to take a pointer
   instead of returning one.
3. Actually allocates the info on the stack.

Could you refactor this, please?