Re: [PATCH v3] spi: cadence-xspi: Support 32bit and 64bit slave dma interface

[Nathan Chancellor]

On Thu, Jun 04, 2026 at 11:30:27AM +0100, Mark Brown wrote:
> On Thu, Jun 04, 2026 at 07:51:12AM +0800, Jisheng Zhang wrote:
> > On Wed, Jun 03, 2026 at 09:20:29AM +0100, Mark Brown wrote:
> 
> > > readsq() and writesq() are only defined under CONFIG_64BIT AFAICT, but
> > > the driver will build on 32 bit.  We need to configure out this option
> > > on 32 bit architectures.
> 
> > Currently, the cadence-xspi has depended on 64BIT, the dependency was
> > introduced by commit d58ecc54bb09 ("spi: cadence: Add 64BIT Kconfig
> > dependency") for marvell sdma handling. So we have two choices:
> 
> Ah, the patch is fine then - I must have been looking at a fixes tree
> without the dependency when I reviewed it, I'd forgotten that Marvell
> update had gone in.

Your 7.2 tree has commit 0c5b5c40dc31 ("spi: cadence-xspi: Add
COMPILE_TEST support") in it, so this driver does build on 32-bit
platforms now. -next is broken with

  drivers/spi/spi-cadence-xspi.c:601:4: error: call to undeclared function 'readsq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    601 |                         readsq(src, buf, len >> 3);
        |                         ^
  drivers/spi/spi-cadence-xspi.c:623:4: error: call to undeclared function 'writesq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    623 |                         writesq(dst, buf, len >> 3);
        |                         ^
  2 errors generated.

which would not happen if the 64BIT dependency was there. If
0c5b5c40dc31 is to remain around, it seems like option A upthread is
needed.

-- 
Cheers,
Nathan