Re: [PATCH] fs: efs: Fix compilation bug and use pr_debug()

[Andrew Morton]

On Thu, 4 Jun 2026 20:40:30 -0500 Maxwell Doose <m32285159@xxxxxxxxx> wrote:

> On Thu, Jun 4, 2026 at 4:30 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > (cc linux-fsdevel)
> >
> 
> Whoops, I guess I'm too reliant on --cc-cmd :(
> 
> > On Thu,  4 Jun 2026 15:24:40 -0500 Maxwell Doose <m32285159@xxxxxxxxx> wrote:
> >
> > > Firstly, the current code uses formatters that are incompatible with the
> > > most recent GCC for x86_64. Replace them and explicitly cast the
> > > formatted variables to their respective forms of long long.
> >
> > Please quote the compiler output in the changelog.
> >
> 
> It's rather lengthy:
> fs/efs/file.c: In function ‘efs_get_block’:
> fs/efs/file.c:26:35: error: ‘block’ undeclared (first use in this
> function); did you mean ‘iblock’?

Right.  You're evidently the first person who tried to compile this in
more than 20 years.

How about we just delete it all?  If some future developer wants to
know block numbers and stuff, they know how to use printk.