Re: [PATCH] crypto: tegra: fix refcount leak in tegra_se_host1x_submit()
From: Akhil R
Date: Fri Jun 05 2026 - 01:35:10 EST
On Thu, 4 Jun 2026 10:27:06 +0000, Wentao Liang wrote:
> The timeout error path in tegra_se_host1x_submit() returns without
> calling host1x_job_put(), while all other paths (success, submit
> error, pin error) properly release the job reference through the
> job_put label. Since host1x_job_alloc() initializes the reference
> count and host1x_job_put() is required to drop it, omitting it on
> timeout causes a permanent refcount leak.
>
> Fix this by redirecting the timeout return to the existing job_put
> label, ensuring the job reference and any associated syncpt
> references are consistently released.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 0880bb3b00c8 ("crypto: tegra - Add Tegra Security Engine driver")
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>
Thanks for the patch.
Reviewed-by: Akhil R <akhilrajeev@xxxxxxxxxx>
Best Regards,
Akhil