Re: [PATCH] iio: backend: fix uninitialized data in debugfs

From: Dan Carpenter

Date: Fri Jun 05 2026 - 02:18:03 EST


On Thu, Jun 04, 2026 at 05:55:08PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 04, 2026 at 01:42:11PM +0300, Dan Carpenter wrote:
> > On Thu, Jun 04, 2026 at 01:38:50PM +0300, Dan Carpenter wrote:
> > > 168 ret = sscanf(buf, "%i %i", &back->cached_reg_addr, &val);
> > > ^^^
> > > Uninitialized variable.
> >
> > s/variable/data/.
>
> With what I asked in the previous reply and what you explained there
> (thanks, btw!) I still think your patches are not fully correct. They
> will require to atomically write all or nothing. If we want support
> partial writes we need to go with that differently (reset ppos when
> we got enough or more than enough data).

Requiring writes to syfs and debugfs be atomic is pretty normal and
works well in practice. These are very small writes.

regards,
dan carpenter