Re: [PATCH 1/2] regulator: dt-bindings: qcom,sdm845-refgen-regulator: Document IPQ9650

[Kathiravan Thirumoorthy]

On 6/4/2026 8:42 PM, Krzysztof Kozlowski wrote:
> On 02/06/2026 11:21, Kathiravan Thirumoorthy wrote:
> > IPQ9650 has two REFGEN blocks which provide reference current to the PCIe,
> > USB and UNIPHY PHYs. Unlike other supported platforms, IPQ9650 requires the
> > REFGEN clocks to be enabled explicitly.
> >
> > Document the IPQ9650 compatible and the required clocks for it.
> >
> > Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@xxxxxxxxxxxxxxxx>
> > ---
> >   .../regulator/qcom,sdm845-refgen-regulator.yaml     | 21 +++++++++++++++++++++
> >   1 file changed, 21 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml
> > index 40f9223d4c27..2686569ca060 100644
> > --- a/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml
> > +++ b/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml
> > @@ -16,6 +16,16 @@ description:
> >   allOf:
> >     - $ref: regulator.yaml#
> >   
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: qcom,ipq9650-refgen-regulator
> > +    then:
> > +      required:
> > +        - clocks
> > +        - clock-names
> Entire allOF block goes to the end, see example-schema.

Since the allOf already at the top of the file, I just added under it. 
Let me move it to the end.

> > +
> >   properties:
> >     compatible:
> >       oneOf:
> > @@ -29,6 +39,7 @@ properties:
> >   
> >         - items:
> >             - enum:
> > +              - qcom,ipq9650-refgen-regulator
> >                 - qcom,qcs8300-refgen-regulator
> >                 - qcom,sa8775p-refgen-regulator
> >                 - qcom,sc7280-refgen-regulator
> > @@ -45,6 +56,16 @@ properties:
> >     reg:
> >       maxItems: 1
> >   
> > +  clocks:
> > +    items:
> > +      - description: Core reference clock
> > +      - description: AHB interface clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: core
> > +      - const: hclk
> You just added clocks to each variant, which is not explained in commit
> msg. And it would be a separate commit anyway. Probably you wanted to
> add proper constraints (:false).

Ack, will make the change to define the clock and clock-names only for 
IPQ9650 compatible under the allOf block.

> Best regards,
> Krzysztof