Re: [PATCH v3 1/5] rust: inline some init methods

[Gary Guo]

On Thu Jun 4, 2026 at 3:59 PM BST, Alexandre Courbot wrote:
> On Wed Jun 3, 2026 at 8:52 PM JST, Gary Guo wrote:
>> On Fri May 29, 2026 at 4:27 PM BST, Alexandre Courbot wrote:
>>> These methods should be inlined for optimization reasons. Failure to do
>>> so can also produce symbol names larger than what `modpost` or `objtool`
>>> can handle.
>>> 
>>> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
>>
>> Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>
>
> Hi Gary,
>
> Sashiko suggested (and I tend to agree) to also inline the following
> methods for consistency:
>
> - InPlaceInit::init
> - UniqueArc::init_with
> - UniqueArc::pin_init_with
>
> Does your `Reviewed-by` still hold with these methods added?

Yes, it's fine to keep the tag.

Best,
Gary