Re: [PATCH v5 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding and add mahua

[Krzysztof Kozlowski]

On Tue, Jun 02, 2026 at 01:02:17AM -0700, Qiang Yu wrote:
> The QREF block supplies reference clocks to PCIe PHYs and requires
> dedicated LDO supplies to operate. The digital control interface for
> QREF (clkref_en registers) resides in TCSR on glymur and mahua. Since
> QREF has no dedicated DT node of its own, these supply properties are
> placed in the TCSR node which acts as the control interface for QREF.
> 
> Add a dedicated binding file for qcom,glymur-tcsr and qcom,mahua-tcsr and
> document the supply properties. Both SoCs share the same QREF TX/RPT/RX

I would prefer if adding new compatible - mahua - would be in a separate
commit. Moving Glymur while adding missing supplies is actually one
logical change. Mahua is a second one.

> component naming, but differ in topology:
> 
> Glymur has two independent QREF blocks fed by REFGEN3 and REFGEN4. Mahua
> has a single QREF block fed by REFGEN3 only.
> 
> Mark the relevant supplies as required per compatible using allOf/if/then
> conditionals.
> 
> Signed-off-by: Qiang Yu <qiang.yu@xxxxxxxxxxxxxxxx>
> ---
>  .../bindings/clock/qcom,glymur-tcsr.yaml           | 146 +++++++++++++++++++++
>  .../bindings/clock/qcom,sm8550-tcsr.yaml           |   2 -
>  2 files changed, 146 insertions(+), 2 deletions(-)

Everything else looks fine.

Best regards,
Krzysztof