Re: [PATCH v2 1/5] crypto: hisilicon/zip - add backlog support for zip

[Herbert Xu]

On Thu, May 28, 2026 at 07:55:27PM +0800, ZongYu Wu wrote:
> From: Chenghai Huang <huangchenghai2@xxxxxxxxxx>
> 
> When the hardware queue is busy, requests are now queued instead of
> being failed immediately. Queued requests are retried when earlier
> requests complete, which prevents transient failures under heavy load.
> 
> The backlog path also provides a fallback mechanism while the hardware
> is temporarily unavailable, such as during device reset.
> 
> Signed-off-by: Chenghai Huang <huangchenghai2@xxxxxxxxxx>
> Signed-off-by: Zongyu Wu <wuzongyu1@xxxxxxxxxx>
> ---
>  drivers/crypto/hisilicon/zip/zip_crypto.c | 286 ++++++++++++++--------
>  1 file changed, 183 insertions(+), 103 deletions(-)

We already have a generic queueing mechanism in the form of
crypto_engine.

Please add support for acomp to it instead of rolling your own
queueing mechanism.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt