Re: [PATCH v3] block: assign caller-specific lockdep class to disk->open_mutex
From: Mark Brown
Date: Fri Jun 05 2026 - 08:13:29 EST
On Fri, Jun 05, 2026 at 01:02:59PM +0200, Miguel Ojeda wrote:
> On Fri, Jun 5, 2026 at 12:15 PM Tetsuo Handa
> <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote:
> > I am using my tree for allowing syzbot to test debug/experimental patches in linux-next tree
> linux-next is only meant for patches that are already reviewed, tested
> and destined for the merge window.
> It is not meant for experimental patches, and adding those, especially
> this late in the kernel cycle, can break other people's CIs and
> systems at the worst possible time. If every maintainers put random
> patches in linux-next, then it would be unusable...
> (There are exceptions, of course, but only if people is aware and in
> agreement...)
In general the sort of testing that it's good for is "this needs more
exposure" sorts of things - things that look good locally but where
there's a wide variety of users or affected systems that might be
affected and where it's hard to judge the impact.
> > Do you see any technical problems except comment style problem?
> The above errors are already a technical problem -- they break the
> Clippy and docs build!
Oh, bah - something turned off RUST in allmodconfig again so we lost
coverage in -next, sorry about that. I'll need to work something out to
make sure I notice that happening and can do something about it. It's
kind of worrying that this keeps happening TBH, otherwise rust conflicts
are likely to result in broken builds. The dependencies feel really
fraigle here.
> No, please drop it now -- the patch shouldn't have been applied to
> linux-next yet, since the maintainers didn't ack it (they just
> realized it exists...), it is not reviewed (apart from Sashiko), it is
> not tested enough (given the errors above) and not destined for the
> next merge window (for all the reasons before).
Had the rust builds been enabled for allmodconfig as I had expected the
tree would have been kept out of -next as a result of this.
Attachment:
signature.asc
Description: PGP signature