Re: [PATCH v2 1/2] dt-bindings: media: i2c: add aptina,mt9m113

[Conor Dooley]

On Fri, Jun 05, 2026 at 05:38:55AM +0200, Herman van Hazendonk via B4 Relay wrote:
> From: Herman van Hazendonk <github.com@xxxxxxxxxx>
> 
> Add the binding for the Aptina (now ON Semiconductor) MT9M113 1.3
> megapixel SoC image sensor with on-die ISP. The chip is used as the
> front (user-facing) camera on the HP TouchPad tablet and connects
> to the host SoC over MIPI CSI-2.
> 
> The binding describes the chip's i2c address, optional reset and
> standby GPIOs, the per-supply regulators (VDD, VDD_IO, VDDA), the
> external clock input, and the CSI-2 endpoint pads exposed via the
> "port" subnode.
> 
> Signed-off-by: Herman van Hazendonk <github.com@xxxxxxxxxx>
> ---
>  .../bindings/media/i2c/aptina,mt9m113.yaml         | 127 +++++++++++++++++++++
>  1 file changed, 127 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml
> new file mode 100644
> index 000000000000..7fa7cb2fedf9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9m113.yaml
> @@ -0,0 +1,127 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/aptina,mt9m113.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Aptina MT9M113 1.3 Megapixel CMOS Digital Image Sensor
> +
> +maintainers:
> +  - Herman van Hazendonk <github.com@xxxxxxxxxx>
> +
> +description: |-
> +  The Aptina MT9M113 is a 1.3 Megapixel CMOS digital image sensor with
> +  1280x1024 active pixels. It supports dual context operation:
> +  Context A (640x480 preview mode with binning) and Context B (1280x1024
> +  capture mode). It is programmable through an I2C interface and outputs
> +  image data over a 1-lane MIPI CSI-2 connection.
> +
> +properties:
> +  compatible:
> +    const: aptina,mt9m113
> +
> +  reg:
> +    description: I2C device address
> +    enum:
> +      - 0x3c
> +      - 0x48
> +      - 0x5d
> +
> +  clocks:
> +    description: EXTCLK clock signal (24 MHz typical)
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description:
> +      Core digital voltage supply, 1.8V
> +
> +  vddio-supply:
> +    description:
> +      I/O digital voltage supply, 1.8V or 2.8V
> +
> +  vaa-supply:
> +    description:
> +      Analog voltage supply, 2.8V
> +
> +  reset-gpios:
> +    description: |-

Neither this or powerdown should need the |-, there's no formatting here
that needs preservation.

> +      Reference to the GPIO connected to the RESET_BAR pin, if any (active
> +      low).
> +
> +  powerdown-gpios:
> +    description: |-
> +      Reference to the GPIO connected to the STANDBY/PWDN pin, if any (active
> +      high). When asserted, the sensor enters low-power standby mode.
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          bus-type:
> +            const: 4
> +            description: MIPI CSI-2 D-PHY
> +
> +          link-frequencies: true
> +          remote-endpoint: true
> +          data-lanes:
> +            minItems: 1

This minItems shouldn't be needed, the maxItems should suffice.

> +            maxItems: 1
> +
> +        required:
> +          - bus-type
> +          - link-frequencies
> +          - data-lanes
> +
> +    required:
> +      - endpoint
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - vdd-supply
> +  - vddio-supply
> +  - vaa-supply
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/media/video-interfaces.h>
> +
> +    i2c0 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        camera@3c {
> +            compatible = "aptina,mt9m113";
> +            reg = <0x3c>;
> +
> +            clocks = <&mmcc 48>;
> +
> +            reset-gpios = <&pm8058_gpio 29 GPIO_ACTIVE_LOW>;
> +            powerdown-gpios = <&pm8058_gpio 30 GPIO_ACTIVE_HIGH>;
> +
> +            vddio-supply = <&pm8058_l15>;
> +            vdd-supply = <&pm8058_l15>;
> +            vaa-supply = <&pm8058_l14>;
> +
> +            port {
> +                mt9m113_ep: endpoint {

This label here should be dropped, cos it has nothing referencing it.

Otherwise, this looks good to me.
pw-bot: changes-requested

Cheers,
Conor.

> +                    bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> +                    link-frequencies = /bits/ 64 <384000000>;
> +                    data-lanes = <1>;
> +                    remote-endpoint = <&csiphy1_ep>;
> +                };
> +            };
> +        };
> +    };
> +...
> 
> -- 
> 2.43.0
> 
>

Attachment: signature.asc
Description: PGP signature