RE: [PATCH net-next v3 08/14] net: ethernet: oa_tc6: Remove FCS size in RX frame

[Selvamani Rajagopal]

> 
> Hi Rajagopal,
> 
> Thanks - confirmed: with patch 08 applied, lan865x just needs the FCS
> handling, and s2500 gets it via hw_features |= NETIF_F_RXFCS.
> 
> Two things though:
> (1) I had dropped patch 08 in my tree, hence the separate strip patch.
> (2) Patch 08 uses NETIF_F_RXFCS inverted from its kernel meaning
> ("append FCS"): it strips when the bit is in hw_features and checks
> hw_features rather than dev->features, so ethtool -K rx-fcs on never
> actually delivers the FCS, and a consumer must advertise a debug feature
> to get default behavior. The mainline idiom (r8169, rtase, 8139too, mlx4)
> is if (!(dev->features & NETIF_F_RXFCS)) strip;
> with hw_features |= NETIF_F_RXFCS to allow toggling. Since every OA TC6
> device delivers the FCS, I'd suggest the framework strip unconditionally
> by default using that idiom (patch attached), rather than gating on a
> per-vendor opt-in.
> 
> Please consider.


Yes. Of course. I will make those changes before submitting v4. We want the flag
to be used consistently.