Re: [PATCH 0/4] perf timechart: Fix memory leaks

From: Arnaldo Carvalho de Melo

Date: Fri Jun 05 2026 - 19:21:23 EST


On Fri, Jun 05, 2026 at 04:11:51PM -0700, Namhyung Kim wrote:
> Hello,
>
> This patchset fixes memory leaks in the perf timechart code.
> I've extended and verified the timechart test with ASAN.

Hi Namhyung,

You submitted a series for timechart before, so I had to go on
looking if this was a second version or a different series.

I suggest you always have a version in the cover letter, i.e.:

[PATCH v1 0/4] perf timechart: Fix memory leaks

To avoid this brief distraction :-)

Regards,

- Arnaldo

> Thanks,
> Namhyung
>
>
> Namhyung Kim (4):
> perf timechart: Release event samples at the end
> perf timechart: Fix memory leaks during record
> perf timechart: Fix memory leaks in draw_wakeups()
> perf test: Update perf timechart test
>
> tools/perf/builtin-timechart.c | 93 ++++++++++++++++++++++++-----
> tools/perf/tests/shell/timechart.sh | 24 +++++---
> 2 files changed, 94 insertions(+), 23 deletions(-)
>
> --
> 2.54.0.1032.g2f8565e1d1-goog