Re: [PATCH v4 2/5] iio: adc: add Versal SysMon driver

From: Andy Shevchenko

Date: Sun Jun 07 2026 - 04:08:24 EST


On Sun, Jun 07, 2026 at 11:06:13AM +0300, Andy Shevchenko wrote:
> On Sat, Jun 06, 2026 at 06:17:04AM +0100, Salih Erim wrote:

Ah, and missed part below.

...

> > +#ifndef _VERSAL_SYSMON_H_
> > +#define _VERSAL_SYSMON_H_
> > +
> > +#include <linux/bits.h>
> > +#include <linux/mutex.h>

> > +#include <linux/types.h>

types.h is not used here.

> > +struct device;

> > +struct iio_dev;

Neither this forward declaration.

> > +struct regmap;

--
With Best Regards,
Andy Shevchenko