RE: [PATCH net-next v4 13/16] onsemi: s2500: Add driver support for TS2500 MAC-PHY

From: Selvamani Rajagopal

Date: Sun Jun 07 2026 - 15:25:38 EST


> Subject: Re: [PATCH net-next v4 13/16] onsemi: s2500: Add driver support for TS2500
> MAC-PHY
>
> > + the questions about onsemi ethernet devices. If you say Y, you
> > + will be asked for your specific card in the following questions.
>
> Above line should be indented with one tab + spaces.


Sorry about that. Will fix the formatting issue in both Kconfig files,
one under onsemi and one under onsemi/s2500.


> > + /**
>
> Use /*
> since this is not a kernel-doc comment.
>

Yes. will fix it.


> > + * Convert unsigned scaled_ppm to atto-seconds per clock cycles.
> > + * The scaled_ppm format is Qx.16 --> 1 lsb = 1/65536 ppm.
> > + * The clock period of the S2500 is 8ns (125 MHz), so 1 lsb of